[U-Boot] [PATCH] vboot: Do not use hashed-strings offset

MISC:https://lists.denx.de/pipermail/u-boot/2018-June/330454.html


Download: text/x-diff
Original: lists.denx.de
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<HTML>
 <HEAD>
   <TITLE> [U-Boot] [PATCH] vboot: Do not use hashed-strings offset
   </TITLE>
   <LINK REL="Index" HREF="index.html" >
   <LINK REL="made" HREF="mailto:u-boot%40lists.denx.de?Subject=Re%3A%20%5BU-Boot%5D%20%5BPATCH%5D%20vboot%3A%20Do%20not%20use%20hashed-strings%20offset&In-Reply-To=%3C20180603144650.0a2f1ac5840f3276efdb8a34%40gmail.com%3E">
   <META NAME="robots" CONTENT="index,nofollow">
   <style type="text/css">
       pre {
           white-space: pre-wrap;       /* css-2.1, curent FF, Opera, Safari */
           }
   </style>
   <META http-equiv="Content-Type" content="text/html; charset=utf-8">
   <LINK REL="Previous"  HREF="330906.html">
   <LINK REL="Next"  HREF="330910.html">
 </HEAD>
 <BODY BGCOLOR="#ffffff">
   <H1>[U-Boot] [PATCH] vboot: Do not use hashed-strings offset</H1>
    <B>Teddy Reed</B> 
    <A HREF="mailto:u-boot%40lists.denx.de?Subject=Re%3A%20%5BU-Boot%5D%20%5BPATCH%5D%20vboot%3A%20Do%20not%20use%20hashed-strings%20offset&In-Reply-To=%3C20180603144650.0a2f1ac5840f3276efdb8a34%40gmail.com%3E"
       TITLE="[U-Boot] [PATCH] vboot: Do not use hashed-strings offset">teddy.reed at gmail.com
       </A><BR>
    <I>Sun Jun  3 18:46:50 UTC 2018</I>
    <P><UL>
        <LI>Previous message: <A HREF="330906.html">[U-Boot] [PATCH 1/1] rockchip: doc: clarify usage of	CONFIG_SPL_ROCKCHIP_BACK_TO_BROM
</A></li>
        <LI>Next message: <A HREF="330910.html">[U-Boot] [PATCH] vboot: Do not use hashed-strings offset
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#330454">[ date ]</a>
              <a href="thread.html#330454">[ thread ]</a>
              <a href="subject.html#330454">[ subject ]</a>
              <a href="author.html#330454">[ author ]</a>
         </LI>
       </UL>
    <HR>  
<!--beginarticle-->
<PRE>
The hashed-strings signature property includes two uint32_t values.
The first is unneeded as there should never be a start offset into the
strings region. The second, the size, is needed because the added
signature node appends to this region.

See tools/image-host.c, where a static 0 value is used for the offset.

Signed-off-by: Teddy Reed &lt;<A HREF="https://lists.denx.de/listinfo/u-boot">teddy.reed at gmail.com</A>&gt;
---
 common/image-sig.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/common/image-sig.c b/common/image-sig.c
index f65d883..9b0a872 100644
--- a/common/image-sig.c
+++ b/common/image-sig.c
@@ -372,8 +372,7 @@ int fit_config_check_sig(const void *fit, int noffset, int required_keynode,
 	/* Add the strings */
 	strings = fdt_getprop(fit, noffset, &quot;hashed-strings&quot;, NULL);
 	if (strings) {
-		fdt_regions[count].offset = fdt_off_dt_strings(fit) +
-				fdt32_to_cpu(strings[0]);
+		fdt_regions[count].offset = fdt_off_dt_strings(fit);
 		fdt_regions[count].size = fdt32_to_cpu(strings[1]);
 		count++;
 	}
-- 
2.7.4

</PRE>








































































































































<!--endarticle-->
    <HR>
    <P><UL>
        <!--threads-->
	<LI>Previous message: <A HREF="330906.html">[U-Boot] [PATCH 1/1] rockchip: doc: clarify usage of	CONFIG_SPL_ROCKCHIP_BACK_TO_BROM
</A></li>
	<LI>Next message: <A HREF="330910.html">[U-Boot] [PATCH] vboot: Do not use hashed-strings offset
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#330454">[ date ]</a>
              <a href="thread.html#330454">[ thread ]</a>
              <a href="subject.html#330454">[ subject ]</a>
              <a href="author.html#330454">[ author ]</a>
         </LI>
       </UL>

<hr>
<a href="https://lists.denx.de/listinfo/u-boot">More information about the U-Boot
mailing list</a><br>
</body></html>
© CVE.report 2022 Twitter Nitter Twitter Viewer |

Use of this information constitutes acceptance for use in an AS IS condition. There are NO warranties, implied or otherwise, with regard to this information or its use. Any use of this information is at the user's risk. It is the responsibility of user to evaluate the accuracy, completeness or usefulness of any information, opinion, advice or other content. EACH USER WILL BE SOLELY RESPONSIBLE FOR ANY consequences of his or her direct or indirect use of this web site. ALL WARRANTIES OF ANY KIND ARE EXPRESSLY DISCLAIMED. This site will NOT BE LIABLE FOR ANY DIRECT, INDIRECT or any other kind of loss.

CVE, CWE, and OVAL are registred trademarks of The MITRE Corporation and the authoritative source of CVE content is MITRE's CVE web site. This site includes MITRE data granted under the following license.

CVE.report and Source URL Uptime Status status.cve.report