hfsplus: prevent corruption in shrinking truncate
Summary
| CVE | CVE-2021-46989 |
|---|---|
| State | PUBLISHED |
| Assigner | Linux |
| Source Priority | CVE Program / NVD first with legacy fallback |
| Published | 2024-02-28 09:15:37 UTC |
| Updated | 2026-08-04 10:16:39 UTC |
| Description | In the Linux kernel, the following vulnerability has been resolved: hfsplus: prevent corruption in shrinking truncate I believe there are some issues introduced by commit 31651c607151 ("hfsplus: avoid deadlock on file truncation") HFS+ has extent records which always contains 8 extents. In case the first extent record in catalog file gets full, new ones are allocated from extents overflow file. In case shrinking truncate happens to middle of an extent record which locates in extents overflow file, the logic in hfsplus_file_truncate() was changed so that call to hfs_brec_remove() is not guarded any more. Right action would be just freeing the extents that exceed the new size inside extent record by calling hfsplus_free_extents(), and then check if the whole extent record should be removed. However since the guard (blk_cnt > start) is now after the call to hfs_brec_remove(), this has unfortunate effect that the last matching extent record is removed unconditionally. To reproduce this issue, create a file which has at least 10 extents, and then perform shrinking truncate into middle of the last extent record, so that the number of remaining extents is not under or divisible by 8. This causes the last extent record (8 extents) to be removed totally instead of truncating into middle of it. Thus this causes corruption, and lost data. Fix for this is simply checking if the new truncated end is below the start of this extent record, making it safe to remove the full extent record. However call to hfs_brec_remove() can't be moved to it's previous place since we're dropping ->tree_lock and it can cause a race condition and the cached info being invalidated possibly corrupting the node data. Another issue is related to this one. When entering into the block (blk_cnt > start) we are not holding the ->tree_lock. We break out from the loop not holding the lock, but hfs_find_exit() does unlock it. Not sure if it's possible for someone else to take the lock under our feet, but it can cause hard to debug errors and premature unlocking. Even if there's no real risk of it, the locking should still always be kept in balance. Thus taking the lock now just before the check. |
Risk And Classification
Primary CVSS: v3.1 5.5 MEDIUM from ADP
CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H
Problem Types: NVD-CWE-Other | CWE-noinfo Not enough information
| Version | Source | Type | Score | Severity | Vector |
|---|---|---|---|---|---|
| 3.1 | ADP | DECLARED | 5.5 | MEDIUM | CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H |
| 3.1 | 416baaa9-dc9f-4396-8d5f-8c081fb06d67 | Secondary | 7.1 | HIGH | CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:H/A:H |
| 3.1 | 134c704f-9b21-4f2e-91b3-4a467353bcc0 | Secondary | 5.5 | MEDIUM | CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H |
| 3.1 | CNA | DECLARED | 7.1 | HIGH | CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:H/A:H |
CVSS v3.1 Breakdown
Attack Vector
LocalAttack Complexity
LowPrivileges Required
LowUser Interaction
NoneScope
UnchangedConfidentiality
NoneIntegrity
NoneAvailability
HighCVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H
NVD Known Affected Configurations (CPE 2.3)
| Type | Vendor | Product | Version | Update | Edition | Language |
|---|---|---|---|---|---|---|
| Operating System | Linux | Linux Kernel | All | All | All | All |
Vendor Declared Affected Products
| Source | Vendor | Product | Version | Platforms |
|---|---|---|---|---|
| CNA | Linux | Linux | affected 31651c607151f1034cfb57e5a78678bea54c362b 52dde855663e5db824af51db39b5757d2ef3e28a git | Not specified |
| CNA | Linux | Linux | affected 31651c607151f1034cfb57e5a78678bea54c362b c451a6bafb5f422197d31536f82116aed132b72c git | Not specified |
| CNA | Linux | Linux | affected 31651c607151f1034cfb57e5a78678bea54c362b adbd8a2a8cc05d9e501f93e5c95c59307874cc99 git | Not specified |
| CNA | Linux | Linux | affected 31651c607151f1034cfb57e5a78678bea54c362b c477f62db1a0c0ecaa60a29713006ceeeb04b685 git | Not specified |
| CNA | Linux | Linux | affected 31651c607151f1034cfb57e5a78678bea54c362b 97314e45aa1223a42d60256a62c5d9af54baf446 git | Not specified |
| CNA | Linux | Linux | affected 31651c607151f1034cfb57e5a78678bea54c362b c3187cf32216313fb316084efac4dab3a8459b1d git | Not specified |
| CNA | Linux | Linux | affected 4.19 | Not specified |
| CNA | Linux | Linux | unaffected 4.19 semver | Not specified |
| CNA | Linux | Linux | unaffected 4.19.191 4.19.* semver | Not specified |
| CNA | Linux | Linux | unaffected 5.4.120 5.4.* semver | Not specified |
| CNA | Linux | Linux | unaffected 5.10.38 5.10.* semver | Not specified |
| CNA | Linux | Linux | unaffected 5.11.22 5.11.* semver | Not specified |
| CNA | Linux | Linux | unaffected 5.12.5 5.12.* semver | Not specified |
| CNA | Linux | Linux | unaffected 5.13 * original_commit_for_fix | Not specified |
References
| Reference | Source | Link | Tags |
|---|---|---|---|
| git.kernel.org/stable/c/52dde855663e5db824af51db39b5757d2ef3e28a | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/adbd8a2a8cc05d9e501f93e5c95c59307874cc99 | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/c477f62db1a0c0ecaa60a29713006ceeeb04b685 | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/97314e45aa1223a42d60256a62c5d9af54baf446 | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/c3187cf32216313fb316084efac4dab3a8459b1d | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/c451a6bafb5f422197d31536f82116aed132b72c | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| CVE Program record | CVE.ORG | www.cve.org | canonical |
| NVD vulnerability detail | NVD | nvd.nist.gov | canonical, analysis |
No vendor comments have been submitted for this CVE.