usb: gadget: f_fs: Fix race between aio_cancel() and AIO request complete
Summary
| CVE | CVE-2024-36894 |
|---|---|
| State | PUBLISHED |
| Assigner | Linux |
| Source Priority | CVE Program / NVD first with legacy fallback |
| Published | 2024-05-30 16:15:12 UTC |
| Updated | 2026-05-12 12:16:48 UTC |
| Description | In the Linux kernel, the following vulnerability has been resolved: usb: gadget: f_fs: Fix race between aio_cancel() and AIO request complete FFS based applications can utilize the aio_cancel() callback to dequeue pending USB requests submitted to the UDC. There is a scenario where the FFS application issues an AIO cancel call, while the UDC is handling a soft disconnect. For a DWC3 based implementation, the callstack looks like the following: DWC3 Gadget FFS Application dwc3_gadget_soft_disconnect() ... --> dwc3_stop_active_transfers() --> dwc3_gadget_giveback(-ESHUTDOWN) --> ffs_epfile_async_io_complete() ffs_aio_cancel() --> usb_ep_free_request() --> usb_ep_dequeue() There is currently no locking implemented between the AIO completion handler and AIO cancel, so the issue occurs if the completion routine is running in parallel to an AIO cancel call coming from the FFS application. As the completion call frees the USB request (io_data->req) the FFS application is also referencing it for the usb_ep_dequeue() call. This can lead to accessing a stale/hanging pointer. commit b566d38857fc ("usb: gadget: f_fs: use io_data->status consistently") relocated the usb_ep_free_request() into ffs_epfile_async_io_complete(). However, in order to properly implement locking to mitigate this issue, the spinlock can't be added to ffs_epfile_async_io_complete(), as usb_ep_dequeue() (if successfully dequeuing a USB request) will call the function driver's completion handler in the same context. Hence, leading into a deadlock. Fix this issue by moving the usb_ep_free_request() back to ffs_user_copy_worker(), and ensuring that it explicitly sets io_data->req to NULL after freeing it within the ffs->eps_lock. This resolves the race condition above, as the ffs_aio_cancel() routine will not continue attempting to dequeue a request that has already been freed, or the ffs_user_copy_work() not freeing the USB request until the AIO cancel is done referencing it. This fix depends on commit b566d38857fc ("usb: gadget: f_fs: use io_data->status consistently") |
Risk And Classification
Primary CVSS: v3.1 5.6 MEDIUM from ADP
CVSS:3.1/AV:P/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:H
Problem Types: CWE-362 | CWE-362 CWE-362 Concurrent Execution using Shared Resource with Improper Synchronization ('Race Condition')
| Version | Source | Type | Score | Severity | Vector |
|---|---|---|---|---|---|
| 3.1 | ADP | DECLARED | 5.6 | MEDIUM | CVSS:3.1/AV:P/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:H |
| 3.1 | 134c704f-9b21-4f2e-91b3-4a467353bcc0 | Secondary | 5.6 | MEDIUM | CVSS:3.1/AV:P/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:H |
CVSS v3.1 Breakdown
Attack Vector
PhysicalAttack Complexity
HighPrivileges Required
LowUser Interaction
NoneScope
UnchangedConfidentiality
HighIntegrity
NoneAvailability
HighCVSS:3.1/AV:P/AC:H/PR:L/UI:N/S:U/C:H/I:N/A:H
NVD Known Affected Configurations (CPE 2.3)
| Type | Vendor | Product | Version | Update | Edition | Language |
|---|---|---|---|---|---|---|
| Operating System | Linux | Linux Kernel | All | All | All | All |
Vendor Declared Affected Products
| Source | Vendor | Product | Version | Platforms |
|---|---|---|---|---|
| CNA | Linux | Linux | affected 2e4c7553cd6f9c68bb741582dcb614edcbeca70f f71a53148ce34898fef099b75386a3a9f4449311 git | Not specified |
| CNA | Linux | Linux | affected 2e4c7553cd6f9c68bb741582dcb614edcbeca70f 9e72ef59cbe61cd1243857a6418ca92104275867 git | Not specified |
| CNA | Linux | Linux | affected 2e4c7553cd6f9c68bb741582dcb614edcbeca70f e500b1c4e29ad0bd1c1332a1eaea2913627a92dd git | Not specified |
| CNA | Linux | Linux | affected 2e4c7553cd6f9c68bb741582dcb614edcbeca70f 3613e5023f09b3308545e9d1acda86017ebd418a git | Not specified |
| CNA | Linux | Linux | affected 2e4c7553cd6f9c68bb741582dcb614edcbeca70f a0fdccb1c9e027e3195f947f61aa87d6d0d2ea14 git | Not specified |
| CNA | Linux | Linux | affected 2e4c7553cd6f9c68bb741582dcb614edcbeca70f 73c05ad46bb4fbbdb346004651576d1c8dbcffbb git | Not specified |
| CNA | Linux | Linux | affected 2e4c7553cd6f9c68bb741582dcb614edcbeca70f d7461830823242702f5d84084bcccb25159003f4 git | Not specified |
| CNA | Linux | Linux | affected 2e4c7553cd6f9c68bb741582dcb614edcbeca70f 24729b307eefcd7c476065cd7351c1a018082c19 git | Not specified |
| CNA | Linux | Linux | affected 3.15 | Not specified |
| CNA | Linux | Linux | unaffected 3.15 semver | Not specified |
| CNA | Linux | Linux | unaffected 4.19.317 4.19.* semver | Not specified |
| CNA | Linux | Linux | unaffected 5.4.279 5.4.* semver | Not specified |
| CNA | Linux | Linux | unaffected 5.10.221 5.10.* semver | Not specified |
| CNA | Linux | Linux | unaffected 5.15.162 5.15.* semver | Not specified |
| CNA | Linux | Linux | unaffected 6.1.95 6.1.* semver | Not specified |
| CNA | Linux | Linux | unaffected 6.6.31 6.6.* semver | Not specified |
| CNA | Linux | Linux | unaffected 6.8.10 6.8.* semver | Not specified |
| CNA | Linux | Linux | unaffected 6.9 * original_commit_for_fix | Not specified |
| ADP | Linux | Linux Kernel | affected 2e4c7553cd6f 73c05ad46bb4 custom | Not specified |
| ADP | Linux | Linux Kernel | affected 2e4c7553cd6f d74618308232 custom | Not specified |
| ADP | Linux | Linux Kernel | affected 2e4c7553cd6f 24729b307eef custom | Not specified |
| ADP | Linux | Linux Kernel | affected 2e4c7553cd6f f71a53148ce3 custom | Not specified |
| ADP | Linux | Linux Kernel | affected 2e4c7553cd6f 9e72ef59cbe6 custom | Not specified |
| ADP | Linux | Linux Kernel | affected 2e4c7553cd6f e500b1c4e29a custom | Not specified |
| ADP | Linux | Linux Kernel | affected 2e4c7553cd6f 3613e5023f09 custom | Not specified |
| ADP | Linux | Linux Kernel | affected 2e4c7553cd6f a0fdccb1c9e0 custom | Not specified |
| ADP | Linux | Linux Kernel | affected 3.15 | Not specified |
| ADP | Linux | Linux Kernel | unaffected 3.15 custom | Not specified |
| ADP | Linux | Linux Kernel | unaffected 4.19.317 4.20 custom | Not specified |
| ADP | Linux | Linux Kernel | unaffected 5.4.279 5.5 custom | Not specified |
| ADP | Linux | Linux Kernel | unaffected 5.10.221 5.11 custom | Not specified |
| ADP | Linux | Linux Kernel | unaffected 5.15.162 5.16 custom | Not specified |
| ADP | Linux | Linux Kernel | unaffected 6.1.95 6.2 custom | Not specified |
| ADP | Linux | Linux Kernel | unaffected 6.6.31 6.7 custom | Not specified |
| ADP | Linux | Linux Kernel | unaffected 6.8.10 6.9 custom | Not specified |
| ADP | Linux | Linux Kernel | unaffected 6.9 * custom | Not specified |
| ADP | Siemens | RUGGEDCOM RST2428P | unaffected * custom | Not specified |
| ADP | Siemens | SCALANCE XC-300/XR-300/XC-400/XR-500WG/XR-500 Family | unaffected * custom | Not specified |
| ADP | Siemens | SCALANCE XCM-/XRM-/XCH-/XRH-300 Family | unaffected * custom | Not specified |
| ADP | Siemens | SIMATIC S7-1500 TM MFP - GNU/Linux Subsystem | affected * custom | Not specified |
References
| Reference | Source | Link | Tags |
|---|---|---|---|
| git.kernel.org/stable/c/a0fdccb1c9e027e3195f947f61aa87d6d0d2ea14 | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/73c05ad46bb4fbbdb346004651576d1c8dbcffbb | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/d7461830823242702f5d84084bcccb25159003f4 | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/3613e5023f09b3308545e9d1acda86017ebd418a | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| cert-portal.siemens.com/productcert/html/ssa-265688.html | 0b142b55-0307-4c5a-b3c9-f314f3fb7c5e | cert-portal.siemens.com | |
| git.kernel.org/stable/c/f71a53148ce34898fef099b75386a3a9f4449311 | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/9e72ef59cbe61cd1243857a6418ca92104275867 | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| git.kernel.org/stable/c/24729b307eefcd7c476065cd7351c1a018082c19 | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| cert-portal.siemens.com/productcert/html/ssa-355557.html | 0b142b55-0307-4c5a-b3c9-f314f3fb7c5e | cert-portal.siemens.com | |
| lists.debian.org/debian-lts-announce/2025/01/msg00001.html | af854a3a-2127-422b-91ae-364da2661108 | lists.debian.org | |
| git.kernel.org/stable/c/e500b1c4e29ad0bd1c1332a1eaea2913627a92dd | af854a3a-2127-422b-91ae-364da2661108 | git.kernel.org | Patch |
| CVE Program record | CVE.ORG | www.cve.org | canonical |
| NVD vulnerability detail | NVD | nvd.nist.gov | canonical, analysis |
No vendor comments have been submitted for this CVE.
There are currently no legacy QID mappings associated with this CVE.